Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Illuminate\Events\Dispatcher::fire()` removed in 5.8 #5

Closed
GreenImp opened this issue May 17, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@GreenImp
Copy link
Contributor

commented May 17, 2019

In Laravel 5.8, the Illuminate\Events\Dispatcher::fire() method has been deprecated removed from the codebase, meaning that whenever this package triggers and event it throws a fatal error:

Call to undefined method Illuminate\Events\Dispatcher::fire()

This can be fixed by replacing::fire() with ::dispatch(). I'm happy to put a pull request together if you're okay with that?

@mkwsra

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Yes, for sure it's okay and if you aren't free I will do so very soon

@GreenImp

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2019

Fab, I've created a pull request which should fix the problem. I've not been able to test it properly though. You can see my comment on the pull request.

@mkwsra

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Thank you!

@mkwsra mkwsra closed this May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.