Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dockerfile rp bacalhau #170

Merged

Conversation

AquiGorka
Copy link
Contributor

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

These changes make it so that the docker image for the resource-provider + bacalhau services are packed together into a docker image and jobs can be ran from the cli and onchain.

Task/Issue reference

Implements: #93

Details (optional)

bacalhau runs jobs in docker so the dind images is used to be able to execute the docker daemon.

How to test this code? (optional)

In different terminals:

  1. ./stack chain-clean && ./stack chain
  2. ./stack chain-boot
  3. ./stack solver
  4. ./stack job-creator
  5. ./stack resource-provider-docker-build && ./stack resource-provider-docker-run
  6. ./stack run-cowsay-onchain <- verify the correct result
  7. ./stack run cowsay:v0.0.4 -i Message="yay" <- verify the correct result
  8. ./stack integration-tests <- verify pass ok

@taoshengshi
Copy link
Contributor

taoshengshi commented Jun 20, 2024

It passed all the test in my local env. ship it!

image

@taoshengshi taoshengshi self-requested a review June 20, 2024 14:07
Copy link
Contributor

@taoshengshi taoshengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all the cases locally and they all passed. This is very convenient for quickly setting up a local test network! ship it!

@AquiGorka AquiGorka merged commit c9189eb into build/dockerfile-one-RP-bacalhau Jun 20, 2024
@AquiGorka AquiGorka deleted the gorka/fix-dockerfile-rp-bacalhau branch June 20, 2024 17:30
AquiGorka added a commit that referenced this pull request Jun 20, 2024
* build:one dockerfile for resource provider and bacalhau (refactor by comments)

* udpate bacalhau from 1.3.0 to 1.3.2

* fix: dockerfile rp bacalhau (#170)

* refactor: update dockerfile to build from source and use dind

* refactor: update docker build and run helper scripts for resource provider

* feat: if the env var is not set do not include it in bacalhau's env

* fix: dockerfile

* fix: stack

---------

Co-authored-by: Gorka Ludlow <gorka@aquigorka.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants