Skip to content
Permalink
Browse files Browse the repository at this point in the history
Fixed issue #15680: LimeSurvey 3.21.1 Cross Site Scripting Stored
  • Loading branch information
lacrioque committed Dec 19, 2019
1 parent 6d15b90 commit 0a7bdfa
Showing 1 changed file with 19 additions and 4 deletions.
23 changes: 19 additions & 4 deletions application/views/admin/token/tokenform.php
Expand Up @@ -147,15 +147,21 @@
<?php eT("First name:"); ?>
</label>
<div class="">
<input class='form-control' type='text' size='30' id='firstname' name='firstname' value="<?php if (isset($firstname)) {echo $firstname; } ?>" />
<?=TbHtml::textField('firstname', $firstname, [
'class' => 'form-control',
'size' => '30',
]);?>
</div>
</div>
<div class="form-group">
<label class=" control-label" for='lastname'>
<?php eT("Last name:"); ?>
</label>
<div class="">
<input class='form-control' type='text' size='30' id='lastname' name='lastname' value="<?php if (isset($lastname)) {echo $lastname; } ?>" />
<?=TbHtml::textField('lastname', $lastname, [
'class' => 'form-control',
'size' => '30',
]);?>
</div>
</div>

Expand Down Expand Up @@ -189,7 +195,11 @@
<?php eT("Email:"); ?>
</label>
<div class="">
<input class='form-control' type='text' maxlength='320' size='50' id='email' name='email' value="<?php if (isset($email)) {echo $email; } ?>" />
<?=TbHtml::emailField('email', $email, [
'class' => 'form-control',
'size' => '50',
'maxlength' => '320'
]);?>
</div>
</div>

Expand All @@ -199,7 +209,12 @@
<?php eT("Email status:"); ?>
</label>
<div class="">
<input class='form-control' type='text' maxlength='320' size='50' id='emailstatus' name='emailstatus' placeholder='OK' value="<?php if (isset($emailstatus)) {echo $emailstatus; } else {echo " OK "; }?>" />
<?=TbHtml::textField('emailstatus', $emailstatus, [
'class' => 'form-control',
'size' => '50',
'maxlength' => '320',
'placeholder' => 'OK'
]);?>
</div>
</div>

Expand Down

9 comments on commit 0a7bdfa

@guramj
Copy link

@guramj guramj commented on 0a7bdfa Mar 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Since this issue is already resolved, could you please assign CVE for this vulnerability?
Thanks!

@guramj
Copy link

@guramj guramj commented on 0a7bdfa Mar 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also, would it be possible to disclose this vulnerability to public? https://bugs.limesurvey.org/view.php?id=15680

Thanks!

@maziminke
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olleharstedt How do we deal with such disclosures and CVE requests in general?

@guramj
Copy link

@guramj guramj commented on 0a7bdfa Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always there is never response from LimeSurvey team!

@guramj
Copy link

@guramj guramj commented on 0a7bdfa Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please assign CVE to this vulnerability? Thanks.

@maziminke
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-schmitz please take action...

@guramj
Copy link

@guramj guramj commented on 0a7bdfa May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olleharstedt & @c-schmitz, I am trying to request a CVE number for the following vulnerabilities, which I reported them back in December, 2019.
https://bugs.limesurvey.org/view.php?id=15680
https://bugs.limesurvey.org/view.php?id=15681
https://bugs.limesurvey.org/view.php?id=15672

I am no longer able to browse on to the above links to view my reported vulnerabilities. Could you please let me access them through the bugs.limesurvey website. And also could you please mark these vulnerabilities as PUBLIC?

Regards,
Guram.

@olleharstedt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, see other thread.

@guramj
Copy link

@guramj guramj commented on 0a7bdfa May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olleharstedt

Please sign in to comment.