Skip to content
Permalink
Browse files

Fixed issue #15908: No input fields for admin login page after update

  • Loading branch information
olleharstedt committed Mar 12, 2020
1 parent 8164fb4 commit ac4e0ac8ffb8a0c1521a1061d7738a5620123528
Showing with 5 additions and 1 deletion.
  1. +5 −1 application/libraries/PluginManager/PluginManager.php
@@ -480,7 +480,11 @@ public function loadPlugins()
}

foreach ($records as $record) {
if (!isset($record->load_error) || $record->load_error == 0) {
if (!isset($record->load_error)
|| $record->load_error == 0
// NB: Authdb is hardcoded since updating sometimes causes error.
// @see https://bugs.limesurvey.org/view.php?id=15908
|| $record->name == 'Authdb') {
$this->loadPlugin($record->name, $record->id);
}
}

5 comments on commit ac4e0ac

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

@Shnoulle Shnoulle replied Mar 13, 2020

Why not something related to plugin ?

public function beforeDeactivate()
{
$this->getEvent()->set('success', false);
// Optionally set a custom error message.
$this->getEvent()->set('message', gT('Core plugin can not be disabled.'));
}

Maybe we can create some config.xml settings

  • deactivate_allowed : false/true
  • unload_on_error : false/true
  • .... other idea
@olleharstedt

This comment has been minimized.

Copy link
Contributor Author

@olleharstedt olleharstedt replied Mar 13, 2020

Yeah, this is a hacky quick-fix. We can discuss other solutions on Mantis.

@olleharstedt

This comment has been minimized.

Copy link
Contributor Author

@olleharstedt olleharstedt replied Mar 13, 2020

Maybe XML option ignore_load_error. For the truly brave. ;)

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

@Shnoulle Shnoulle replied Mar 13, 2020

then when dev , can set ignore_load_error to true ;)

@olleharstedt

This comment has been minimized.

Copy link
Contributor Author

@olleharstedt olleharstedt replied Mar 13, 2020

Ah yes, true, another use-case that should be covered.

Please sign in to comment.
You can’t perform that action at this time.