Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #14398: Unable to set a different standardthemerootdir than default one #1201

Merged
merged 3 commits into from Jan 9, 2019

Conversation

Projects
None yet
1 participant
@Shnoulle
Copy link
Collaborator

commented Jan 4, 2019

Dev: get core template list from standardthemerootdir
Dev: Set DB settings by copnfig.php settings in default TemplateManifest

Fixed issue #14398: Unable to set a different standardthemerootdir th…
…an default one

Dev: get core template list from standardthemerootdir
Dev: Set DB settings by copnfig.php settings in default TemplateManifest
@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 4, 2019

Still an issue after TRUNCATE the theme table : think we must try to install default theme if it's not installed

@Shnoulle Shnoulle changed the title Fixed issue #14398: Unable to set a different standardthemerootdir than default one [WIP] Fixed issue #14398: Unable to set a different standardthemerootdir than default one Jan 5, 2019

Shnoulle added some commits Jan 7, 2019

Dev: Fixed issue : allow to update final default theme
Dev: check if need install and install it if not …

@Shnoulle Shnoulle changed the title [WIP] Fixed issue #14398: Unable to set a different standardthemerootdir than default one Fixed issue #14398: Unable to set a different standardthemerootdir than default one Jan 7, 2019

@Shnoulle Shnoulle requested a review from LouisGac Jan 7, 2019

@Shnoulle Shnoulle merged commit 1b74ddf into LimeSurvey:master Jan 9, 2019

2 of 3 checks passed

CodeFactor 1 issue fixed. 2 issues found.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.