New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #14400: Unable to use self ot that fixed string in Expression #1202

Merged
merged 6 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@Shnoulle
Copy link
Collaborator

Shnoulle commented Jan 7, 2019

Fixed issue #14400: Unable to use self or that fixed string in Expression
Dev: add self,that and this in reserved var for Question rules
Fixed issue : don't replace title starting with self or that in expression

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

Shnoulle commented Jan 7, 2019

Sill have issue with question title as selfToto

Fixed

@Shnoulle Shnoulle changed the title [WIP] 14400: Unable to use self ot that fixed string in Expression Fixed issue #14400: Unable to use self ot that fixed string in Expression Jan 7, 2019

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

Shnoulle commented Jan 7, 2019

CodeFactor is unhappy :/ But in general : CodeFactor didn't like EM …

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

Shnoulle commented Jan 7, 2019

@maziminke : i think it's OK now BUT : i like more testing with this fix. Since current 3.15 is old … think i wait next release to merge (and then have a week to test)

@Shnoulle Shnoulle merged commit ab247ba into LimeSurvey:master Jan 9, 2019

2 of 3 checks passed

CodeFactor 13 issues fixed. 14 issues found.
Details
Scrutinizer 1 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment