New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#14495: error with P type and comment suffix #1213

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@realitix
Copy link
Contributor

realitix commented Feb 6, 2019

Fixed issue #14495

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

Shnoulle commented Feb 6, 2019

See mantis comment : must fix it in model ( import, api, plugin etc … must use same rules)

And remind to read https://manual.limesurvey.org/Coding_guidelines (it's OK) and https://manual.limesurvey.org/Standard_for_Git_commit_messages (but currently we squash and merge in general)

@realitix

This comment has been minimized.

Copy link
Contributor Author

realitix commented Feb 7, 2019

I updated the pull request with your indication. It works!

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

Shnoulle commented Feb 7, 2019

@realitix OK, seems excellent, thank you.
Just a final question : did you try to fix

function fixNumbering($iQuestionID, $iSurveyID)
in this pull request ?

  • if yes : i wait for the fix
  • if no : i squash and merge and see what happen with a previous survey :)

@Shnoulle Shnoulle self-assigned this Feb 7, 2019

@realitix

This comment has been minimized.

Copy link
Contributor Author

realitix commented Feb 8, 2019

Helle @Shnoulle.
I didn't try to fix the fixNumbering function because with this pull request, the problem is fixed earlier.
So you can merge it.

Thanks

@Shnoulle Shnoulle merged commit a47c09d into LimeSurvey:master Feb 8, 2019

3 checks passed

CodeFactor 1 issue fixed. 1 issue found.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Shnoulle

This comment has been minimized.

Copy link
Collaborator

Shnoulle commented Feb 8, 2019

OK, great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment