Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Added docker stack #1233

Open
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
6 participants
@eiabea
Copy link

commented Feb 25, 2019

  • Add alpine docker file
  • Add docker-compose file to start limesurvey with database
  • Update readme
  • Build and push image to Docker Hub
  • Add official limesurvey image to docker-compose file instead of building

eiabea added some commits Nov 30, 2018

Updated php and limesurvey
Added volume

@LouisGac LouisGac changed the base branch from master to develop Feb 25, 2019

@LouisGac

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

hey, no new feature to master please. From now, you must submit the PR to Develop.

@eiabea

This comment has been minimized.

Copy link
Author

commented Feb 26, 2019

Making Changes
Please avoid working directly on the master branch

... sorry, my bad!

@adamzammit

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

Also please have a look at the work already done here: https://github.com/martialblog/docker-limesurvey and here: https://github.com/adamzammit/limesurvey-docker

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

About docker : yes, i think it great to have a docker setup, but this don't realy need to be in LimeSurvey/LimeSurvey repo , no ?

Mayve have a LimeSurvey/Docker (with different setup : some with pgsql, some with mysql for example etc …)

@eiabea

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

@adamzammit thank you for the repos, i think a combination of all 3 attempts would be great. I was primarily aiming to create a small image of LimeSurvey everytime a new release gets pushed. The docker-compose file was kind of a bonus to test it out, but i'd love to see a official image of LimeSurvey at DockerHub
@Shnoulle great idea, but this has to be created by some of the maintainers

@Shnoulle

This comment has been minimized.

Copy link
Collaborator

commented Feb 27, 2019

great idea, but this has to be created by some of the maintainers

@c-schmitz : what is your opinion about a Docker repo with different branch ?

@martialblog

This comment has been minimized.

Copy link

commented Mar 5, 2019

Hey,

I'd to add that I've been working on a flexible Dockerfile for a while now: https://github.com/martialblog/docker-limesurvey

Feel free to use that.

Cheers

EDIT: Just saw that my name was already mentioned 🤦‍♂

@martialblog

This comment has been minimized.

Copy link

commented Mar 5, 2019

@Shnoulle If you want to start a new repo for this (probably should right?) feel free to fork my stuff. I can also help with maintaining if that's necessary/

@martialblog

This comment has been minimized.

Copy link

commented Apr 27, 2019

Jello, any update on this?

@olleharstedt

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Looks good!

libpng-dev \
&& rm -rf /var/lib/apt/lists/*

RUN curl -o limesurvey.zip https://download.limesurvey.org/latest-stable-release/limesurvey3.15.9+190214.zip \

This comment has been minimized.

Copy link
@olleharstedt

olleharstedt May 7, 2019

Contributor

Release number should not be hard-coded.

This comment has been minimized.

Copy link
@martialblog

This comment has been minimized.

Copy link
@olleharstedt

olleharstedt May 7, 2019

Contributor

Sure. But it seems hard-coded in there too?

This comment has been minimized.

Copy link
@martialblog

martialblog May 7, 2019

That is usually the case though. For example: https://github.com/nextcloud/docker/blob/master/16.0/apache/Dockerfile or https://github.com/jenkinsci/docker/blob/master/Dockerfile

Since you want some validation of what version is inside. What would you prefer?

This comment has been minimized.

Copy link
@olleharstedt

olleharstedt May 7, 2019

Contributor

I'd prefer if the version would automatically be greped from the tags in the git repo.

This comment has been minimized.

Copy link
@martialblog

martialblog May 7, 2019

I like @Shnoulle 's idea of creating a separate repo for the Docker code, keeping things clean in the main repo... with the Docker examples and tests and whatnot.

You can then build the Images automatically via Travis or something like Hubot, or have one of these humans I've heard so much about do it. I created a little shell helper for that already, updating the version and checksum.

This comment has been minimized.

Copy link
@olleharstedt

This comment has been minimized.

Copy link
@martialblog

martialblog May 9, 2019

As I said before, feel free to fork/use my repo.

@martialblog

This comment has been minimized.

Copy link

commented Jun 26, 2019

Jello, any updates on this yet? It's been a while 🐱

@lacrioque lacrioque force-pushed the LimeSurvey:develop branch from f10e7b4 to 9513adf Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.