Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][DONTMERGE] Dev: 400 update step by step #1384

Open
wants to merge 1 commit into
base: master
from

Conversation

@Shnoulle
Copy link
Collaborator

Shnoulle commented Feb 7, 2020

For discussion.

Alternate way : 390 + 391 + 392 ?

Current major issue : if it broke during 400 upgrade and show a solution (and user have DB access) : there are no way to launch again the upgrade process

@Shnoulle Shnoulle requested review from c-schmitz, maziminke and olleharstedt Feb 7, 2020
@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Feb 7, 2020

@maziminke maybe you have broken DB ? Then we can test if fix the error returned directly inside DB and relauch upgrade process can work.

@olleharstedt

This comment has been minimized.

Copy link
Contributor

olleharstedt commented Feb 10, 2020

IMO, first step is to move all dropTable to the end of the update.

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Feb 10, 2020

IMO, first step is to move all dropTable to the end of the update.

More work for user : right ?

@olleharstedt

This comment has been minimized.

Copy link
Contributor

olleharstedt commented Feb 10, 2020

More work for user : right ?

If it fails? Yes, the restore procedure would be manual.

@olleharstedt

This comment has been minimized.

Copy link
Contributor

olleharstedt commented Feb 10, 2020

But less testing for us (me).

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Feb 10, 2020

1st step : have some broken DB (with mariadb or pg)

@olleharstedt

This comment has been minimized.

Copy link
Contributor

olleharstedt commented Feb 10, 2020

1st step : have some broken DB (with mariadb or pg)

Easy, just manipulate the collation before upgrading to LS4.

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Feb 10, 2020

Maybe but must have too different errors. I see some pk in Label (really don't understand how this can happen ....)

@explorerdk

This comment has been minimized.

Copy link

explorerdk commented Feb 10, 2020

I have the same issue, I had to rollback to backup copy of Site / DB, if helpful i will supply a copy of Database for debugging.... the same error posted on Mantis Bug report is what it does to me also. Tried changing collation, but that did not help with the 1st error.

My Survey DB is not to big either.,.

/Explorerdk

@olleharstedt

This comment has been minimized.

Copy link
Contributor

olleharstedt commented Feb 10, 2020

@explorerdk You should write something on Mantis so that we know more people are affected. Thank you.

@maziminke

This comment has been minimized.

Copy link
Collaborator

maziminke commented Feb 10, 2020

Currently I can't share a broken DB due to privacy issues, sorry.

@explorerdk

This comment has been minimized.

Copy link

explorerdk commented Feb 10, 2020

Currently I can't share a broken DB due to privacy issues, sorry.

@maziminke I have mine Anonymized, so I was proposing to share my small Survey db :)

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Feb 14, 2020

@olleharstedt

IMO, first step is to move all dropTable to the end of the update.

What i can do is :

  1. remove the step by step
  2. move the drip table at end
  3. Keep the checking of XX_400 existence before working on XX and use the _400 one by rename ? (for example question_400 exist ; delete question + questioni10n, rename question_400 to question and try again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.