Skip to content

remotecontrol API - JSON-RPC #147

Closed
wants to merge 4 commits into from

3 participants

@VincentBiragnet

Hi,

I had problem with the api and the way I build my json request. Parameters in my json wasn't ordered the way limesurvey wanted and some optional parameters were missing. I think that my request had to be legal anyway.
So I decided to update limesurvey's code accordingly.

So now, with my commit:
1) parameter order is no more mandatory for parameters
2) default values are added if API call omits some optional parameters

I'd be glad if you accept this change,

Kind regards,

Vincent

Vincent Bira... and others added some commits Oct 14, 2013
Vincent Biragnet Resolve bugs in RemoteControl json-RPC API.
Now:
1) order is no more mandatory for parameters
2) default values are added if API call omits some optional parameters
f93cbdf
Vincent Biragnet Resolve bugs in RemoteControl json-RPC API.
Now:
1) order is no more mandatory for parameters
2) default values are added if API call omits some optional parameters
b53527f
Vincent Biragnet Merge branch 'master' of
https://github.com/VincentBiragnet/LimeSurvey.git

Conflicts:
	application/libraries/LSjsonRPCServer.php
6824420
@VincentBiragnet VincentBiragnet Update LSjsonRPCServer.php
typo changed
74e4c08
@c-schmitz
LimeSurvey GmbH member

TBH, I am still trying to understand what this patch does. Can you give an before/after example?

@SamMousa
LimeSurvey GmbH member

Hi @VincentBiragnet,

As far as I know we use JSON-RPC version 1; support for named parameters was introduced in JSON-RPC2. So either you upgraded our API to use JSON-RPC2 or you deviated from the version 1 specs.
Could you tell us which of the 2 you did?

@c-schmitz
LimeSurvey GmbH member

Closed due to missing feedback.

@c-schmitz c-schmitz closed this Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.