Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #07131: Response table shows only a fraction of question : #169

Closed

Conversation

Projects
None yet
2 participants
@Shnoulle
Copy link
Collaborator

Shnoulle commented Jan 24, 2014

  • add Question code (same than EM)
  • Long javascript issue fixed too : really better with long table now: no javascript on ready for qtip/tooltip
  • Don't use content/title otion : seems incompatibility between jquery-ui tooltip and bootsrap tooltip : one is set: none is set (or i made an error somewhere)
  • But set a title allow to easily deactivate functionnality on view for some element
  • Some glitch (show 'real' title) when first enter.
  • USe tooltip (from jq-ui) because seems qtip have some difficulty on event on element with qtip
Fixed issue #07131: Response table shows only a fraction of question …
…: add Question code (same than EM)

Dev: long javascript issue fixed too
Dev: Don't use content/title otion : seems incompatibility between jquery-ui tooltip and bootsrap tooltip : one is set: none is set (or i made an error somewhere)
Dev: But set a title allow to easily deactivate functionnality on view for some element
Dev: Some glitch (show 'real' title) when first enter
@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 24, 2014

capture du 2014-01-24 12 52 48
capture du 2014-01-24 12 53 20

@ghost ghost assigned c-schmitz Jan 24, 2014

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 24, 2014

Think this time it's better.
No tooltip on CSS, but remove whole javascript for tooltip at document.ready.

We make tooltip only oif needed.

I use CHtml::encode for answers. It's better too with question without text but only image.

@Shnoulle Shnoulle closed this Jan 24, 2014

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 24, 2014

Oups ? I closed it ???

@Shnoulle Shnoulle reopened this Jan 24, 2014

Dev: use HTML Purifier in browse response
Dev: think it's the best solution ? Not sure.
@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 25, 2014

Add a fix for browsing response.
Actual solution:
01ls_solution
Think we see nothing : no pic, no information

encode solution:
encode
We are sure to see all, even < script> etc. But not great for image

purify solution:
purify
We remove all scripting and XSS , Great for picture in radio. Think i use it too in export HTML

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 25, 2014

For 2.1: getExtendedAnswer must allow return encode (for string enterd by user) and not encoded (for string in survey).
But : what for csv/other export ?

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 28, 2014

Hi,

I update the fix if needed. But i think of something:
maybe getExtendedAnswer can have an option to have: htmlencode .

Is the answer is a string return by a user (text question type/other/comment): the answer was encode ( < => &tl etc ..) else it return like it was in survey (for singe choice/Yes|no etc ..)

We allways purify when showing, but then we can have
&tl;img src=&quote;test.png&quote; /&gt,
for string entered by user and the image

Showing image
in browse and export (in HTML).

Maybe this option can be used too for another export (csv ? pdf : tcpdf can know some HTML)

@Shnoulle

This comment has been minimized.

Copy link
Collaborator Author

Shnoulle commented Jan 31, 2014

@c-schmitz Is it OK without the purifier or the encode ?

   $purifier->purify(strip_tags(getExtendedAnswer($surveyid, $fnames[$i][0], $dtrow[$fnames[$i][0]], $oBrowseLanguage)))

@Shnoulle Shnoulle closed this in 4a80d96 Feb 1, 2014

@Shnoulle Shnoulle deleted the Shnoulle:master_07131_headerresponsetable_v2 branch Feb 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.