Constraints are overriding type in validation

[igordrnobrega]

Creating an input with type and contraints defined It fails to assert that the type is correct.

public function testOverride()
{
    $input = [
        'price' => 'igor'
    ];

    $inputHandler = new TestConstraintOverrideType();
    $inputHandler->bind($input);
    $this->assertFalse($inputHandler->isValid());
}
 
 class TestConstraintOverrideType extends InputHandler
 {
     public function define()
     {
         $this->add('price', 'int', [
             'required' => true,
             'constraints' => [new Range(0)]
         ]);
     }
 }

[igordrnobrega]

igordrnobrega@e04117a

[igordrnobrega]

Creating an input with type and contraints defined It fails to assert that the type is correct

[nesl247]

The issue is here: https://github.com/LinioIT/input/blob/master/src/Node/BaseNode.php#L68 and https://github.com/LinioIT/input/blob/master/src/Node/BaseNode.php#L161.

The issue is that if the configuration has constraints, it calls setContraints which overrides what is added in the node's constructor.