Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with the new Auto theme setting in macOS Catalina #11

Closed
jtovar43 opened this issue Aug 15, 2019 · 7 comments
Closed

Doesn't work with the new Auto theme setting in macOS Catalina #11

jtovar43 opened this issue Aug 15, 2019 · 7 comments

Comments

@jtovar43
Copy link

I'm running the latest beta of macOS Catalina and the extension still works if you manually change the theme from light to dark. But the extension doesn't seem to work with the new Auto theme that this update brings which switches the OS from light to dark or visa versa based off sunrise and sunset.

@muhelen
Copy link

muhelen commented Oct 27, 2019

Yes, its not working with Catalina public release too.

@cprecioso
Copy link
Contributor

This has already been reported in the helper tool repository: LinusU/DarkModeListener#1

@Nataniel4
Copy link

This feature appears to be supported natively by vscode 🤔

"window.autoDetectColorScheme": true,
"workbench.preferredLightColorTheme": "Default Light+",
"workbench.preferredDarkColorTheme": "Default Dark+"

@michaelgosling
Copy link

That’s a new vscode feature!

@jtovar43
Copy link
Author

Yeah I noticed that the other day too. Glad they finally included it as a feature.

@LinusU
Copy link
Owner

LinusU commented Mar 25, 2020

That's amazing, I'll add a notice to the readme and then we can deprecate this package ☺️

@ChrisChinchilla
Copy link

Wow they snuck that in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants