Linus Unnebäck LinusU

Organizations

@Boxping
LinusU commented on pull request expressjs/multer#131
@LinusU

I have now documented how to implement a storage engine and linked it form the main readme. I think that the only thing that I'm thinking about now…

@LinusU
Should req.files be an array?
LinusU commented on commit expressjs/multer@2bd4ca3277
@LinusU

No it dosen't, have a look at #131, it should have more up to date work

@LinusU
  • @LinusU 9a3e6e4
    doc: custom storage engines
LinusU commented on pull request expressjs/multer#126
@LinusU

I really think that we should keep the other ones in there separate packages. Memory and disk is going to be quite common *and they don't depend on…

LinusU commented on issue expressjs/multer#129
@LinusU

It's not really clear unless you read the spec in full but the nulls are actually only there because of JSON.stringify and it really should be a sp…

LinusU commented on pull request expressjs/multer#131
@LinusU

The field parser is now using LinusU/node-append-field which I just wrote. It makes it both incremental and W3C HTML JSON form spec compliant.

@LinusU
  • @LinusU 05616c6
    spec compliant incremental field parser
LinusU created repository LinusU/node-append-field
LinusU opened issue darobin/formic#39
@LinusU
Clarification in steps to set a JSON encoding value
@LinusU
LinusU deleted tag v0.1.1 at LinusU/testdata-w3c-json-form
@LinusU
@LinusU
  • @LinusU a3d4fd6
    correct handling of sparse arrays
LinusU deleted tag v0.1.1 at LinusU/testdata-w3c-json-form
@LinusU
LinusU commented on pull request expressjs/multer#126
@LinusU

Nice! I left you a message about a bug in the commit, otherwise it looks good! :+1:

@LinusU

If err === null and container === null the resulting line will be cb(null) which dosen't indicate any error. I would recommend doing it like this: if…

LinusU commented on pull request expressjs/multer#131
@LinusU

Just pushed some better error handling, tests for error handling and a workaround for mscdex/busboy#6. It's now also possible to see which field tr…

@LinusU
LinusU commented on issue expressjs/multer#129
@LinusU
@LinusU