From 1b33e92e69215b9fa6256a56b0d0ea9d98c2b128 Mon Sep 17 00:00:00 2001
From: KarielHalling <karihall619@icloud.com>
Date: Thu, 29 May 2025 08:30:48 +0800
Subject: [PATCH] fix: Improve error reporting for Query in fileLoader and
 nonLoader. The Query methods in fileLoader and nonLoader previously either
 returned a "not support" message via the data payload (fileLoader) or failed
 silently (nonLoader), both with a nil error.

This commit changes them to return explicit non-nil errors,
indicating that the Query functionality is not implemented for
these loader types. This aligns better with Go's error handling
conventions and provides clearer feedback to callers.
---
 pkg/testing/loader_file.go | 10 +++++++---
 pkg/testing/loader_non.go  |  5 +++++
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/pkg/testing/loader_file.go b/pkg/testing/loader_file.go
index c3bcb8ca..1183089b 100644
--- a/pkg/testing/loader_file.go
+++ b/pkg/testing/loader_file.go
@@ -18,6 +18,7 @@ package testing
 import (
 	"bytes"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -516,8 +517,11 @@ func (l *fileLoader) Close() {
 }
 
 func (l *fileLoader) Query(query map[string]string) (result DataResult, err error) {
-	result.Pairs = map[string]string{
-		"message": "not support",
-	}
+	err = errors.New("Query functionality is not yet implemented for fileLoader")
+	return
+}
+
+func (l *fileLoader) GetRoundTripper(name string) (roundTripper http.RoundTripper, err error) {
+	err = fmt.Errorf("not support")
 	return
 }
diff --git a/pkg/testing/loader_non.go b/pkg/testing/loader_non.go
index 1a6af49a..714828b6 100644
--- a/pkg/testing/loader_non.go
+++ b/pkg/testing/loader_non.go
@@ -15,6 +15,10 @@ limitations under the License.
 */
 package testing
 
+import (
+	"errors"
+)
+
 // nonLoader is an empty implement for avoid too many nil check
 type nonLoader struct{}
 
@@ -151,5 +155,6 @@ func (l *nonLoader) Close() {
 }
 
 func (l *nonLoader) Query(query map[string]string) (result DataResult, err error) {
+	err = errors.New("Query functionality is not implemented for nonLoader")
 	return
 }