Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centos 8 #61

Merged
merged 2 commits into from Jan 6, 2020
Merged

Add centos 8 #61

merged 2 commits into from Jan 6, 2020

Conversation

@SMillerDev
Copy link
Contributor

SMillerDev commented Jan 5, 2020

No description provided.

@issyl0
issyl0 approved these changes Jan 5, 2020
Copy link
Member

issyl0 left a comment

Travis CI looks broken. All it does it run dockerfilelint. I'll look into porting it to GitHub Actions tomorrow.

Later on in my review there's an existential question about the updatedness of this repo in general, but this addition looks good.

Thanks, Sean!

README.md Outdated Show resolved Hide resolved
```

## Ubuntu 18.04 LTS (Bionic Beaver)
```sh
docker run -it linuxbrew/linuxbrew
docker run -it linuxbrew/brew

This comment has been minimized.

Copy link
@issyl0

issyl0 Jan 5, 2020

Member

Technically this is now Homebrew/brew, but I'm not sure how maintained this repo is in general so maybe this particular nitpick is out of scope.

This comment has been minimized.

Copy link
@sjackman

sjackman Jan 6, 2020

Member

homebrew/brew is preferred over linuxbrew/brew.

This comment has been minimized.

Copy link
@sjackman

sjackman Jan 6, 2020

Member

This line should be

docker build -t linuxbrew-bionic https://raw.githubusercontent.com/Linuxbrew/docker/master/bionic/Dockerfile

This comment has been minimized.

Copy link
@sjackman

sjackman Jan 6, 2020

Member

homebrew/brew is based on Ubuntu 16.04 LTS (Xenial Xerus).

Co-Authored-By: Issy Long <me@issyl0.co.uk>
@issyl0

This comment has been minimized.

Copy link
Member

issyl0 commented Jan 6, 2020

That linting error is pre-existing and unrelated to these changes. I don't know what - if anything - uses that Dockerfile. Going to ignore it for the purposes of this. Thanks again, @SMillerDev!

@issyl0 issyl0 merged commit 51925b9 into Linuxbrew:master Jan 6, 2020
1 check failed
1 check failed
dockerfilelint dockerfilelint
Details
issyl0 added a commit to issyl0/docker that referenced this pull request Jan 6, 2020
- As requested in Linuxbrew#61 (comment).
issyl0 added a commit that referenced this pull request Jan 6, 2020
* The linuxbrew/brew Ubuntu Xenial image is now homebrew/brew

* Give a `docker build` command for the Ubuntu Bionic Linuxbrew image

- As requested in #61 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.