Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The linuxbrew/brew Ubuntu Xenial image is now homebrew/brew #63

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 6, 2020

No description provided.

@issyl0 issyl0 self-assigned this Jan 6, 2020
@issyl0 issyl0 requested a review from sjackman Jan 6, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

There's no point maintaining two supposedly identical Dockerfiles with different names. In fact, they're currently out of sync.

Copy link
Member

sjackman left a comment

These two Dockerfile are different. https://github.com/Homebrew/brew/blob/master/Dockerfile is FROM ubuntu:xenial (Ubuntu LTS 16.04) and this bionic/Dockerifle is FROM ubuntu:bionic (Ubuntu LTS 18.04).

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

Ah, oops. #61 (comment) was wrong then.

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

Is there a plan to bump Homebrew/brew's Dockerfile to use Ubuntu more-recent-than-16.04?

@sjackman

This comment has been minimized.

Copy link
Member

sjackman commented Jan 6, 2020

Is there a plan to bump Homebrew/brew's Dockerfile to use Ubuntu more-recent-than-16.04?

Yes, at some point, but no immediate plans. I'd like to maintain two Docker images, when for our CI, which could continue using Ubuntu 16.04, and one intended for use by end users, which could be upgraded to Ubuntu 18.04, and Ubuntu 20.04 soon enough. We use Ubuntu 16.04 to build bottles so that they can run on older systems.

@issyl0 issyl0 force-pushed the issyl0:linuxbrew/brew-bionic-image-is-now-homebrew/brew branch from dead4ee to 5f2c0bb Jan 6, 2020
@issyl0 issyl0 changed the title The linuxbrew/brew Ubuntu Bionic image is now homebrew/brew The linuxbrew/brew Ubuntu Xenial image is now homebrew/brew Jan 6, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

Thanks, Shaun. I deleted the Xenial Dockerfile here instead and fixed the references.

@maxim-belkin

This comment has been minimized.

Copy link
Member

maxim-belkin commented Jan 6, 2020

Thanks, Sean.

:trollface:

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

Thanks, Sean.

:trollface:

🤦‍♂

- As requested in #61 (comment).
@issyl0 issyl0 requested a review from sjackman Jan 6, 2020
@sjackman

This comment has been minimized.

Copy link
Member

sjackman commented Jan 6, 2020

Thanks, Issy!

@issyl0 issyl0 merged commit 98b586f into Linuxbrew:master Jan 6, 2020
1 check failed
1 check failed
dockerfilelint dockerfilelint
Details
@issyl0 issyl0 deleted the issyl0:linuxbrew/brew-bionic-image-is-now-homebrew/brew branch Jan 6, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

I'm frankly surprised you didn't get me back with "Izzy".

@sjackman

This comment has been minimized.

Copy link
Member

sjackman commented Jan 6, 2020

I thought of that exact thing right after I hit Comment. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.