governor: redo tests; bug fixes; perf improvements #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfanghr
force-pushed
the
connor/governor-negative-tests
branch
12 times, most recently
from
d50780b to
48a4c37
Compare
chfanghr
force-pushed
the
connor/governor-negative-tests
branch
6 times, most recently
from
e465a98 to
f4458bb
Compare
SeungheonOh
reviewed
Jul 20, 2022
There was a problem hiding this comment.
Few things:
Sample/Governor/Mutate.hsshould be moved toProperty/Governor.hsas it's for Property testing only.- I'm unsure if it's a good idea to make
SpecificationTreealso compatible with Properties. We should write new helper for checking scripts with Property testing, and leaveSpecificationTreefor only benchmarking and unit testing. (I'll make new Library for Plutarch Unit testing)
Actually it's still referenced in
Can totally agree with that, |
|
I'll make better interfaces soon. Probably today. |
chfanghr
force-pushed
the
connor/governor-negative-tests
branch
2 times, most recently
from
5a34375 to
5e34fcb
Compare
Merged
chfanghr
force-pushed
the
connor/governor-negative-tests
branch
from
5e34fcb to
d391932
Compare
chfanghr
force-pushed
the
connor/governor-negative-tests
branch
from
d391932 to
23cc230
Compare
Merged
|
Update CHANGELOG.md please! |
emiflake
requested changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #76