Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stake delegation #149

Merged
merged 7 commits into from
Jul 28, 2022
Merged

Stake delegation #149

merged 7 commits into from
Jul 28, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Jul 25, 2022 •
edited
Loading

Will close #95, bases on #146

@chfanghr chfanghr requested a review from emiflake July 25, 2022 14:27
@chfanghr chfanghr marked this pull request as draft July 25, 2022 14:27
@chfanghr chfanghr force-pushed the connor/stake-delegation branch from d82ef06 to 23ab033 Compare July 25, 2022 14:37
@emiflake
Copy link
Member

Update CHANGELOG.md please!

emiflake
emiflake requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple questions.

@chfanghr chfanghr force-pushed the connor/stake-delegation branch 3 times, most recently from 5144033 to 81b5bd4 Compare July 26, 2022 14:15
@chfanghr chfanghr mentioned this pull request Jul 26, 2022
Merged
@chfanghr chfanghr marked this pull request as ready for review July 26, 2022 14:34
@chfanghr chfanghr changed the base branch from connor/governor-negative-tests to staging July 26, 2022 14:36
@chfanghr chfanghr force-pushed the connor/stake-delegation branch from c672a07 to f2ec8b0 Compare July 26, 2022 14:37
emiflake
emiflake approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emiflake emiflake enabled auto-merge July 26, 2022 14:37
auto-merge was automatically disabled July 26, 2022 17:59

Pull request was closed

@SeungheonOh SeungheonOh reopened this Jul 26, 2022
@chfanghr chfanghr enabled auto-merge July 26, 2022 18:00
@emiflake emiflake disabled auto-merge July 28, 2022 10:18
@emiflake emiflake merged commit 01f055d into staging Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow: Stake delegating, use in voting
3 participants
@chfanghr @emiflake @SeungheonOh