Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #174 #175

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Fix #174 #175

merged 2 commits into from
Sep 15, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Sep 15, 2022 •
edited
Loading

Will close #174

@chfanghr chfanghr requested a review from emiflake September 15, 2022 11:55
@chfanghr
fix #174
58653f8 
and also modify test cases to reflect real onchain environment
@chfanghr
update changelog
147920f
@chfanghr chfanghr requested a review from t4ccer September 15, 2022 12:05
emiflake
emiflake approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me! phasOnlyOneTokenOfCurrencySymbol has a bit of a misleading name...

@chfanghr chfanghr merged commit 0be28ba into staging Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

@t4ccer t4ccer Awaiting requested review from t4ccer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid check in governorValidator
2 participants
@chfanghr @emiflake