Apply governor mutation based on existing datum value #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfarrelly
commented
Mar 29, 2023
danielfarrelly
commented
Mar 29, 2023
|
So I added that small change - tested it out with the off-chain and it's working fine it seems. |
danielfarrelly
commented
Apr 13, 2023
t4ccer
reviewed
Apr 13, 2023
emiflake
force-pushed
the
df/governor-mutation-fix
branch
from
3ebc4ad to
7c475a4
Compare
emiflake
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The governor mutation effect as written currently can not be run due to its dependence on the out ref of the governor. The proposal creation step consumes the pinned out ref, preventing it from being consumed later as a part of the effect's execution. This change instead pins the existing datum value of the governor, causing validation of the effect to fail if the value does not match.
Relevant issues
Checklist before requesting a review.
nix run .#ci.