New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voting on Proposals #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfanghr
force-pushed
the
connor/proposal-voting
branch
12 times, most recently
from
May 19, 2022 06:16
a2bf8e6
to
af6d82f
Compare
chfanghr
force-pushed
the
connor/proposal-voting
branch
2 times, most recently
from
May 19, 2022 09:21
f2fd685
to
5eac0ef
Compare
emiflake
requested changes
May 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
.... and mock the value upon creation for now
... hardcoded to 0 upon creation for now
chfanghr
force-pushed
the
connor/proposal-voting
branch
from
May 19, 2022 19:39
0090fc7
to
2f51afb
Compare
chfanghr
force-pushed
the
connor/proposal-voting
branch
3 times, most recently
from
May 20, 2022 13:47
1b1c910
to
acdaac7
Compare
chfanghr
force-pushed
the
connor/proposal-voting
branch
from
May 20, 2022 13:51
acdaac7
to
ccf56f5
Compare
emiflake
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #80