Skip to content
This repository has been archived by the owner. It is now read-only.

Retain votes after cleaned search box - Closes #916 #922

Merged
merged 3 commits into from Oct 26, 2017

Conversation

2 participants
@reyraa
Copy link
Contributor

commented Oct 25, 2017

What's the issue?
Presently we keep the search term in Redux store, but at the time of developing this component we just kept vote list, delegates list and refresh flag. So now changes in the search term cause unintended trigger of loadVotedDelegates.

How did I solve?
Instead of listening for changes of properties, I check if refreshDelegates has been changed from false to true.

There are some other minor code cleanups in this PR.

Closes #916

reyraa added some commits Oct 25, 2017

@reyraa reyraa requested review from slaweet and yasharAyari Oct 25, 2017

@reyraa reyraa self-assigned this Oct 25, 2017

@reyraa reyraa added this to Pull Requests in Version 1.2.1 Oct 25, 2017

@reyraa reyraa added this to Pull Requests in Sprint Board 23-10-17 Oct 25, 2017

@slaweet
Copy link
Contributor

left a comment

Good job @reyraa

@reyraa reyraa merged commit bb6bd3b into 1.2.1 Oct 26, 2017

2 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@reyraa reyraa deleted the 916-search-vote-bug branch Oct 26, 2017

@reyraa reyraa moved this from Pull Requests to Merged Pull Requests in Sprint Board 23-10-17 Oct 26, 2017

@slaweet slaweet moved this from Pull Requests to Merged Pull Requests in Version 1.2.1 Oct 26, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.