Skip to content
This repository has been archived by the owner. It is now read-only.

Fix broken "save account" e2e scenario - Closes #957 #958

Merged
merged 1 commit into from Nov 6, 2017

Conversation

2 participants
@slaweet
Copy link
Contributor

commented Nov 6, 2017

What was the problem?

Scenario: should allow to save account locally, after page reload it should require passphrase to do the first transaction, and remember the passphrase for next transactions was failing

How did I fix it?

By fixing the logic for getting network from the saved account.

How to test it?

npm run e2e-test -s -- --specs features/accountManagement.feature:2

Review checklist

  • The PR solves #957
  • None of our existing unit tests use setState, wrapper.instance.
  • All new code is covered with unit tests
  • All new code follows best practices

@slaweet slaweet force-pushed the 957-make-save-account-e2e-pending branch from b92817b to 05e9de9 Nov 6, 2017

@slaweet slaweet changed the title Make broken e2e scenario temporarily pending #957 Fix broken "save account" e2e scenario - Closes #957 Nov 6, 2017

@slaweet slaweet requested a review from yasharAyari Nov 6, 2017

@slaweet slaweet self-assigned this Nov 6, 2017

@slaweet slaweet added this to Issues in Version 1.3.0 via automation Nov 6, 2017

@slaweet slaweet added this to Issues in Sprint Board 06-11-17 via automation Nov 6, 2017

@slaweet slaweet merged commit c434fc6 into 1.3.0 Nov 6, 2017

3 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 91.087%
Details

Version 1.3.0 automation moved this from Issues to Merged Pull Requests Nov 6, 2017

Sprint Board 06-11-17 automation moved this from Issues to Merged Pull Requests Nov 6, 2017

@slaweet slaweet deleted the 957-make-save-account-e2e-pending branch Nov 6, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.