This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add functionality for handling exceptions present in the blockchain - Closes #3181 #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 26, 2019 17:03
…o 3181-handle_exceptions
SargeKhan
changed the base branch from
development
to
feature/improve_transactions_processing_efficiency
…o 3181-handle_exceptions
shuse2
suggested changes
Mar 28, 2019
framework/src/modules/chain/logic/check_transaction_against_exceptions.js
Show resolved
Hide resolved
| @@ -31,7 +31,7 @@ describe('system test (type 3) - voting with duplicate submissions', () => { | |||
| let t = 0; | |||
|
|
|||
| /* eslint-disable no-loop-func */ | |||
| while (i < 30) { | |||
| while (i < 1) { | |||
There was a problem hiding this comment.
i think i've seen this before too, but probably want to put it back to 30?
framework/test/mocha/integration/transactions/exceptions/duplicate_signatures.js
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,200 @@ | |||
| const expect = require('chai').expect; | |||
There was a problem hiding this comment.
Suggested change
| const expect = require('chai').expect; | |
| const { expect } = require('chai'); |
Also, header required
| @@ -0,0 +1,272 @@ | |||
| const expect = require('chai').expect; | |||
There was a problem hiding this comment.
Suggested change
| const expect = require('chai').expect; | |
| const { expect } = require('chai'); |
Also, header required
mitsuaki-u
reviewed
Apr 1, 2019
|
|
||
| const exceptions = global.exceptions; | ||
|
|
||
| describe('exceptions for multisingature transactions', () => { |
mitsuaki-u
approved these changes
Apr 1, 2019
added 3 commits
April 15, 2019 12:16
…3181-handle_exceptions
…o 3181-handle_exceptions
shuse2
approved these changes
Apr 15, 2019
pablitovicente
suggested changes
Apr 17, 2019
mitsuaki-u
approved these changes
Apr 17, 2019
framework/src/modules/chain/logic/check_transaction_against_exceptions.js
Show resolved
Hide resolved
SargeKhan
force-pushed
the
3181-handle_exceptions
branch
from
ad4052e
to
8a61721
Compare
added 5 commits
April 23, 2019 10:16
SargeKhan
requested review from
pablitovicente,
shuse2 and
mitsuaki-u
and removed request for
pablitovicente and
shuse2
pablitovicente
approved these changes
Apr 23, 2019
mitsuaki-u
approved these changes
Apr 23, 2019
SargeKhan
merged commit e41743b
into
feature/improve_transactions_processing_efficiency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The exceptions in the testnet and mainnet were not handled in the new implementation of transaction processing.
How did I fix it?
Added exception handling logic for various type of exceptions defined in testnet.
How to test it?
Run integration tests for transactions/exceptions/
Review checklist