Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification to LIP and sample code #17

Merged
merged 4 commits into from Jun 17, 2019

Conversation

@janhack
Copy link
Contributor

commented May 28, 2019

  • Clarify the definition of the active set of delegates in the first 2 rounds.
  • Add clarification that forging nodes must not forge while changing to a different chain.
  • Change of terminology from "conflicting blockheaders" to "contradicting blockheaders" to avoid confusion with the term "conflicting blocks".
Add clarification for round offset, clarify that nodes must not forge…
… while switching chain, change terminology from conflicting blockheaders to contradicting blockheaders.

@janhack janhack self-assigned this May 28, 2019

@IkerAlus
Copy link
Member

left a comment

Small comment regarding the forging off requirement.

Also, there is a typo at line 422: "occurred"

Show resolved Hide resolved proposals/lip-0014.md
Show resolved Hide resolved proposals/lip-0014.md Outdated
Show resolved Hide resolved proposals/lip-0014.md
Show resolved Hide resolved proposals/lip-0014.md
Show resolved Hide resolved proposals/lip-0014/LiskBFT.js

@janhack janhack changed the title Add clarification for to LIP and sample code Add clarification to LIP and sample code Jun 3, 2019

@janhack janhack force-pushed the lip-introduce-bft-clarificataion branch from feffb11 to 48bba5e Jun 14, 2019

Show resolved Hide resolved proposals/lip-0014.md Outdated

@janhack janhack requested a review from AndreasKendziorra Jun 14, 2019

@michielmulders
Copy link

left a comment

I agree with your comment. Thanks!

@karmacoma karmacoma merged commit dd620d3 into master Jun 17, 2019

@karmacoma karmacoma deleted the lip-introduce-bft-clarificataion branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.