Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifications and minor specification changes to LIP 0014 #34

Open
wants to merge 12 commits into
base: master
from

Conversation

@janhack
Copy link
Contributor

janhack commented Oct 28, 2019

This PR add some clarifications to LIP 0014 and contains minor specification changes as a result of the implementation work on this LIP.

janhack added 3 commits Oct 28, 2019
janhack added 5 commits Oct 31, 2019
Copy link
Member

IkerAlus left a comment

Just left a clarification comment. The rest looks all good.

proposals/lip-0014.md Outdated Show resolved Hide resolved
Copy link
Contributor

MaximeGagnebin left a comment

Commented on Iker's comment. Approved wether we recommand some number or not.

janhack added 2 commits Nov 4, 2019
@janhack

This comment has been minimized.

Copy link
Contributor Author

janhack commented Nov 4, 2019

I also removed the Javascript prototype code. We can still use it for the specification tests, but in the LIP repository it does not add much value as all relevant parts are already specified as code in the LIP.

@janhack janhack requested review from IkerAlus and MaximeGagnebin Nov 4, 2019
…witching mechansim fails.
@janhack

This comment has been minimized.

Copy link
Contributor Author

janhack commented Nov 4, 2019

I added the information that a peer is banned if it provides an invalid block in the Fast Chain Switching Mechanism.

@janhack janhack requested a review from limiaspasdaniel Nov 4, 2019
@janhack janhack requested review from IkerAlus and MaximeGagnebin Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.