Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Multisignature LIP #38

Merged
merged 7 commits into from Jan 22, 2020
Merged

Update Multisignature LIP #38

merged 7 commits into from Jan 22, 2020

Conversation

@MaximeGagnebin
Copy link
Contributor

MaximeGagnebin commented Jan 15, 2020

Update to multisignature concept:

  • the concept of "second sig accounts" is removed from the Lisk protocol. The same security can be obtained by making the converting the account to a multisignature account with 2 required keys. Therefore, we will disable the "second signature registration" transaction.
  • the way signatures is stored and verified is improved.
  • a multisignature account can now register just 1 public key (previous minimum was 2).
Update to multisignature concept:
- the concept of "second sig accounts" is removed from the Lisk protocol. The same security can be obtained by making the converting the account to a multisignature account with 2 required keys. Therefore, we will disable the "second signature registration" transaction.
- the way `signatures` is stored and verified is improved.
- a multisignature account can now register just 1 public key (previous minimum was 2).
return byteBuffer
serialize_asset_for_multisignature_registration(asset):
let byteBuffer be an empty byte buffer
let lm be the length of the array asset.mandatoryKeys

This comment has been minimized.

Copy link
@pablitovicente

pablitovicente Jan 15, 2020

as we're using some variables in this pseudo code with full words I would do the same for lm and lo that probably mean lengthMandatory and lengthOptional

This comment has been minimized.

Copy link
@MaximeGagnebin

MaximeGagnebin Jan 21, 2020

Author Contributor

changed

Copy link

pablitovicente left a comment

I just made one small suggestion for a pseudocode section and left a question mostly for clarification as it's a bit confusing for me.

Copy link

pablitovicente left a comment

Minor comment pending but ok otherwise.

- changed variable names for pablo's comment.
- added precision about the order of the public keys when converting existing accounts.
@MaximeGagnebin MaximeGagnebin requested review from karmacoma and AndreasKendziorra and removed request for karmacoma Jan 21, 2020
@MaximeGagnebin MaximeGagnebin requested a review from karmacoma Jan 21, 2020
karmacoma added 5 commits Jan 22, 2020
@karmacoma karmacoma merged commit f79349b into master Jan 22, 2020
@karmacoma karmacoma deleted the Update-multisignature-LIP branch Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.