Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the specification that the blockID has to be validated #42

Merged
merged 5 commits into from Feb 13, 2020

Conversation

@AndreasKendziorra
Copy link
Contributor

AndreasKendziorra commented Jan 30, 2020

The id property is a non-required property. Therefore, it should not be validated during block validation. Instead, the blockID should be computed (and overridden if already existing) during block validation, as it is currently done.

The `id` property is a non-required property. Therefore, it should not be validated.
proposals/lip-0020.md Outdated Show resolved Hide resolved
Copy link
Contributor

ricott1 left a comment

I would not say that id is part of a JSON object representing a block. Furthermore I would also change the Bacwards Compatibility and fix a (possible) typo in the specification section

AndreasKendziorra and others added 3 commits Jan 30, 2020
Co-Authored-By: Alessandro Ricottone <ricott2@gmail.com>
@AndreasKendziorra AndreasKendziorra requested a review from ricott1 Jan 30, 2020
@shuse2
shuse2 approved these changes Feb 7, 2020
@AndreasKendziorra AndreasKendziorra requested a review from karmacoma Feb 10, 2020
@karmacoma karmacoma merged commit 62c3342 into master Feb 13, 2020
@karmacoma karmacoma deleted the Remove_ID_validation_from_LIP-0020 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.