Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LIP defining generic serialization #48

Merged
merged 18 commits into from Mar 18, 2020
Merged

Conversation

@MaximeGagnebin
Copy link
Contributor

MaximeGagnebin commented Mar 9, 2020

Add a new LIP defining a generic serialization method.

Add a new LIP defining a generic serialization method.
@MaximeGagnebin MaximeGagnebin self-assigned this Mar 9, 2020
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
@MaximeGagnebin MaximeGagnebin requested review from IkerAlus and removed request for janhack Mar 10, 2020
MaximeGagnebin and others added 8 commits Mar 10, 2020
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-Authored-By: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Copy link
Member

IkerAlus left a comment

Just a small style detail, the rest looks all good.

proposals/lip-maxime_generic_serialization.md Outdated Show resolved Hide resolved
Co-Authored-By: IkerAlus <34474035+IkerAlus@users.noreply.github.com>
@MaximeGagnebin MaximeGagnebin requested review from IkerAlus and pablitovicente and removed request for shuse2 Mar 10, 2020
Copy link
Member

IkerAlus left a comment

Everything looks good to me. Good work!

@MaximeGagnebin MaximeGagnebin requested a review from karmacoma Mar 11, 2020
karmacoma added 4 commits Mar 11, 2020
@karmacoma karmacoma merged commit 9d6a50f into master Mar 18, 2020
@karmacoma karmacoma deleted the LIP-generic_serialization branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.