Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add LIP defining a generic serialization for transactions #49
ricott1 left a comment
Looks all good to me, maybe the only thing is to remove the leading 0x from the signatures and in general bytes values in the bottom example. I think we had some discussion with @AndreasKendziorra and @MaximeGagnebin for the generic serialization LIP, and we decided to use 0x only for numbers. Maybe @AndreasKendziorra can confirm this?
We don't have to be strict about it. I think in this case there is no confusion. The case where I found the usage of "0x" confusing was the little endian varint encoding of an integer which could be false misinterpreted as the regular hex representation of the integer.