From adb53a75f2c6408a19b271c4e4c00ba4edf4e0b6 Mon Sep 17 00:00:00 2001
From: Osvaldo Vega <osvaldo.vega@lightcurve.io>
Date: Thu, 15 Nov 2018 16:12:00 +0100
Subject: [PATCH] :recycle: Changes done after code review

---
 karma.conf.js                         |  3 +-
 src/components/newsFeed/index.test.js | 49 ---------------------------
 test/integration/wallet.test.js       |  2 ++
 3 files changed, 3 insertions(+), 51 deletions(-)
 delete mode 100644 src/components/newsFeed/index.test.js

diff --git a/karma.conf.js b/karma.conf.js
index 1656b1985b..2fc5571c59 100644
--- a/karma.conf.js
+++ b/karma.conf.js
@@ -75,8 +75,7 @@ module.exports = function (config) {
             'src/utils/rawTransactionWrapper.js',
             'src/utils/to.js',
             'src/components/newsFeed/index.js', // This component doesn't meet the setted tresholds for mocha but in jest
-            'src/components/dashboard/currencyGraph.js', // This component should be fixed later, right now the test is being skip (canvas issue)
-            'test/integration/wallet.js', // integration wallet throw random error that should be check it
+            'src/components/dashboard/currencyGraph.js', // This should be unskipped in issue #1499
             'src/components/passphraseCreation/index.js',
           ],
           overrides: {
diff --git a/src/components/newsFeed/index.test.js b/src/components/newsFeed/index.test.js
deleted file mode 100644
index 7b5bc49e35..0000000000
--- a/src/components/newsFeed/index.test.js
+++ /dev/null
@@ -1,49 +0,0 @@
-import React from 'react';
-import sinon from 'sinon';
-import { expect } from 'chai';
-import { mount } from 'enzyme';
-import { Provider } from 'react-redux';
-import { BrowserRouter as Router } from 'react-router-dom';
-import { I18nextProvider } from 'react-i18next';
-import configureMockStore from 'redux-mock-store';
-import thunk from 'redux-thunk';
-
-import i18n from '../../i18n';
-import NewsFeed from './index';
-import * as settingsActions from '../../actions/settings';
-
-describe.skip('NewsFeedHOC', () => {
-  let wrapper;
-  const store = configureMockStore([thunk])({
-    settings: {
-      channels: {},
-    },
-    liskService: {
-      newsFeed: [],
-      showNewsFeedEmptyState: false,
-    },
-    getNewsFeed: sinon.spy(),
-    settingsUpdated: sinon.spy(),
-  });
-
-  beforeEach(() => {
-    wrapper = mount(<Provider store={store}>
-      <Router>
-        <I18nextProvider i18n={ i18n }>
-          <NewsFeed />
-        </I18nextProvider>
-      </Router>
-    </Provider>);
-  });
-
-  it('should render NewsFeed', () => {
-    expect(wrapper).to.have.descendants('NewsFeed');
-  });
-
-  it('should bind settingsUpdated action to Form props.settingsUpdated', () => {
-    const actionsSpy = sinon.spy(settingsActions, 'settingsUpdated');
-    wrapper.find('NewsFeed').props().settingsUpdated({ });
-    expect(actionsSpy).to.be.calledWith({ });
-    actionsSpy.restore();
-  });
-});
diff --git a/test/integration/wallet.test.js b/test/integration/wallet.test.js
index 070a8debd0..919874c660 100644
--- a/test/integration/wallet.test.js
+++ b/test/integration/wallet.test.js
@@ -260,6 +260,7 @@ describe('@integration: Wallet', () => {
       step(`Then I should see text ${successMessage} in "result box message" element`, () => helper.haveTextOf('.result-box-message', successMessage));
     });
 
+    // This should be unskipped in issue #1500
     describe.skip('Scenario: should allow to send LSK from unlocked account with second passphrase', () => {
       const { secondPassphrase } = accounts['second passphrase account'];
       step('Given I\'m on "wallet" as "second passphrase account"', () => setupStep('second passphrase account'));
@@ -391,6 +392,7 @@ describe('@integration: Wallet', () => {
       step('Then I should be redirected to transactoinDetails step', () => helper.checkRedirectionToDetails('123456'));
     });
 
+    // This should be unskipped in issue #1500
     describe.skip('Scenario: should allow to filter transactions', () => {
       step('Given I\'m on "wallet" as "genesis" account', () => setupStep('genesis'));
       step('Then the "All" filter should be selected by default', () => helper.checkSelectedFilter('all'));