Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Block: Filtering should not be available #2639

Closed
Efefefef opened this issue Nov 12, 2019 · 1 comment
Closed

Monitoring: Block: Filtering should not be available #2639

Efefefef opened this issue Nov 12, 2019 · 1 comment
Labels
type: bug unplanned
Projects
Version 1.23.0
Milestone
Sprint 13

Comments

@Efefefef
Copy link
Contributor

Efefefef commented Nov 12, 2019 •
edited

Steps to reproduce

  1. Open Blocks monitor
  2. Click on specific block
  3. Click Filter

Actual result

Opens filter popup with no options

Expected result

No Filter button for Blocks

Version

1.23.0-beta

Screenshot (if appropriate)

image
@Efefefef Efefefef added this to the Sprint 13 milestone Nov 12, 2019
@Efefefef Efefefef added this to Open Issues in Version 1.23.0 via automation Nov 12, 2019
@Efefefef Efefefef changed the title Monitoring: Blocks: Filtering should not be available Monitoring: Block: Filtering should not be available Nov 12, 2019
@slaweet
Copy link
Contributor

slaweet commented Nov 15, 2019

Fixing this should be as simple as changing

lisk-desktop/src/components/shared/filterDropdownButton/index.js

Line 138 in e4dcc3d

return (

to

    return fields.length === 0 ? null : (

This bug happened because when the transactions table was added to the block details page in c6d4787#diff-a2a18b6ed7f14d847fded4da03af69feR210-R215 the TransactionsTable didn't have the filter button, so everything was ok back then.

@reyraa reyraa mentioned this issue Nov 18, 2019
Merged
@reyraa reyraa closed this as completed in 343e57b Nov 18, 2019
Version 1.23.0 automation moved this from Open Issues to Closed Issues Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug unplanned
Projects
No open projects
Version 1.23.0
  
Closed Issues
Milestone
Sprint 13
Development

No branches or pull requests
3 participants
@slaweet @Efefefef @sridharmeganathan