Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint fixings in libs directory - Closes #262 #263

Merged
merged 3 commits into from Aug 28, 2017

Conversation

2 participants
@reyraa
Copy link
Member

commented Aug 25, 2017

To keeps the changes small and possible to review, changes in this PR only aims to fix eslint errors in libs directory. to achieve this, I've enabled eslint before build and I've configured it to run only on libs directory. In future PRs, I'll add other directories one by one as I fix issues there.

Closes #262

@reyraa reyraa self-assigned this Aug 25, 2017

@reyraa reyraa added this to Pending Review in Version 2.0.0 Aug 25, 2017

@reyraa reyraa requested review from karmacoma, MaciejBaj and slaweet Aug 25, 2017

@reyraa reyraa changed the title Eslint fixings - Closes #262 Eslint fixings in libs directory - Closes #262 Aug 28, 2017

@reyraa reyraa merged commit f7d682e into development Aug 28, 2017

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@reyraa reyraa deleted the 262-manual-eslint-fixings branch Aug 28, 2017

@reyraa reyraa moved this from Pending Review to Done in Version 2.0.0 Aug 28, 2017

@reyraa reyraa added this to Merged Pull Requests in Sprint Board 28-08-17 Aug 29, 2017

@reyraa reyraa removed this from Merged Pull Requests in Version 2.0.0 Nov 6, 2017

@reyraa reyraa added this to Merged PRs in Version 1.4.0 Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.