Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with PK Regexp in search Api - Closes #337 #338

Merged
merged 2 commits into from Nov 6, 2017

Conversation

2 participants
@reyraa
Copy link
Member

commented Nov 6, 2017

What was the problem?
I was using /g global flag in my regexps to make sure they'll pass even if we have extra white spaces. but it caused my tests to fail in random.

How did I fix it?
Removed the global flag. I've added some extra fixings in this endpoint.

How to test?
Make sure it:

  • Resolves #337
  • Passes all existing tests
  • Follows Eslint rules

reyraa added some commits Nov 6, 2017

@reyraa reyraa self-assigned this Nov 6, 2017

@reyraa reyraa added bug 🏗 in progress and removed bug labels Nov 6, 2017

@reyraa reyraa requested a review from yasharAyari Nov 6, 2017

@reyraa reyraa merged commit 8a41b46 into 1.3.2 Nov 6, 2017

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@reyraa reyraa deleted the 337-search-api-fixings branch Nov 6, 2017

@reyraa reyraa added ready and removed 👁 pending review labels Nov 6, 2017

@reyraa reyraa added this to Merged Pull Requests in Version 1.3.2 Nov 6, 2017

@reyraa reyraa added this to Merged PRs in Sprint Board 06-11-17 Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.