Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions to 'yourself' are all seen as "account initialization" #1281

Closed
Korben3 opened this issue Sep 12, 2018 · 1 comment

Comments

@Korben3
Copy link

commented Sep 12, 2018

If you send a transaction to yourself using the hub, they are all seen as "account initialization", this look weird/wrong. If an initialization has already performed, the message shouldn't be repeated.

Steps to reproduce

Use the hub to send lisk to your own address.

Actual result

Address is mentioned as "account initialization"

Expected result

Address should mention the senders address.

Solution

Save locally if an "account initialization" is performed. After the first time the hub should mentioned the senders address, even though its the same as the receiver.

Screenshot (if appropriate)

image

@slaweet

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

I agree that it is confusing. However, it is not trivial to always know if a transaction is the first incoming transaction. For example, there can be 1000 incoming transactions and account initialization at the end, but to be sure that the there was no account initialization in between those 1000 transactions, I'd have to fetch all of those from a node, which is a lot of unnecessary traffic.

Now with the reference field, I would rather set "Account initialization" reference when doing the account initialization and always show the address.

EDIT:

Specification

  • Account initialization transaction should set reference "Account initialization"
  • Transaction list should display recipient address instead of "Account initialization" in the Address column of a transaction which has same sender and recipient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.