Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - Transfer - Able to continue with invalid data. #1324

Closed
Korben3 opened this issue Oct 6, 2018 · 0 comments

Comments

@Korben3
Copy link

commented Oct 6, 2018

After clicking on a lisk:// (web)link with invalid data, the data [recipient,reference,amount] is placed in the corresponding fields in lisk hub. But because no check is performed, the user can continue and click "Next".

Steps to reproduce

  1. Open and sign into lisk hub, (stay on the dashboard).
  2. Save the following in test.htm and open the file in a web browser:
    <a href="lisk://wallet?recipient=XXX&amount=YOUCANPRESSNEXT&reference=THISISLONGERTHAN64BYTESDONTTRUSTMEGOAHEADANDCOUNTTHECHARACTERSIAMTELLINGYOUTHISONEISREAL" id="hubLinkUrl">open lisk hub and send transaction</a>
  3. click on the link.
  4. wait for the data to appear in lisk hub, in the wallet section. And click on "Next".

Actual result

User is able to continue/ click "Next". Since the transaction is invalid, nothing happens.

Expected result

After the fields are filled in using the data from the link, a check should be performed to see if the data is valid.

see screenshot
image

@slaweet slaweet added the type: bug label Oct 8, 2018

@slaweet slaweet added this to New Issues in Version 1.4.0 via automation Oct 8, 2018

@slaweet slaweet closed this in 9a74df7 Oct 12, 2018

Version 1.4.0 automation moved this from New Issues to Closed Issues Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.