Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No results found" after finding results #1568

Closed
Korben3 opened this issue Dec 12, 2018 · 2 comments

Comments

@Korben3
Copy link

commented Dec 12, 2018

After a successful search, clicking in the search field again results in a "No results found" message.

Steps to reproduce

  1. Open lisk hub
  2. Search for korben3.
  3. Correct results appear.
  4. Click in the search input field and press enter again, without changing or removing the current value.
  5. Page shows "No results".

Actual result

No results.

Expected result

Show found search results.

Version

1.7.0

Screenshot (if appropriate)

image

@Korben3

This comment has been minimized.

Copy link
Author

commented Dec 12, 2018

In addition the text "No results Search for Lisk ID or Transaction ID" should be "No results Search for Delegate, Lisk ID or Transaction ID"

@slaweet slaweet added this to New Issues in Version 1.10.0 via automation Jan 10, 2019

@slaweet

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@Korben3 Thank you for the report

@Efefefef the condition should be adjusted here:

{ this.state.value !== '' && this.state.resultsLength === 0 ?
<p className={styles.noResults}>{t('No results found')}</p>
: null
}
</div>

  • In the reported scenario, it should still show the results
  • If more than 1 and less than 3 chars are typed, show message "Type at least 3 characters"

Efefefef added a commit that referenced this issue Jan 15, 2019

Merge pull request #1656 from LiskHQ/1568-search-no-results-found
Search fix: suggestions and 3 letters message - Closes #1568

@Efefefef Efefefef closed this Jan 15, 2019

Version 1.10.0 automation moved this from New Issues to Closed Issues Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.