Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the “Add extension” page #1709

Closed
michaeltomasik opened this issue Jan 31, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@michaeltomasik
Copy link
Member

commented Jan 31, 2019

This is a subtask of #1706 epic.
The goal is to

  • Add a new (hidden) page with one input field that allows entering a URL to a *.js file with the code of the extension.
    screen shot 2019-02-06 at 15 24 32
  • The page can be accessed by Lisk launch protocol (e.g. lisk://add-extension)
    Entered URL is saved into local storage and fetched and executed each time the app is launched. This is not the most secure thing, but we shouldn’t worry about that yet, rather focus on making an extension easy and simple.
  • The page should have a link to a feedback form.
  • Adding an extension should for now work only in development mode (npm run dev), and be disabled in the production mode (npm run build) until we put in place some security measures in a future ticket. Disabled should be the "Add extension" button on the "Add extension" page and the page should display a message "Adding extensions is currently disabled in the production version of Lisk Hub. Please refer to Hub developer documentation for instructions on how to run extensions." anywhere. It should also prevent loading extensions if someone manually puts its url to the local storage.

@slaweet slaweet changed the title R&D How to share redux with 3rd party Implement the “Add extension” page Feb 7, 2019

@slaweet slaweet added this to New Issues in Version 1.12.0 via automation Feb 7, 2019

@slaweet slaweet removed this from New Issues in Version 1.12.0 Feb 22, 2019

michaeltomasik added a commit that referenced this issue Mar 22, 2019

@slaweet slaweet closed this Mar 22, 2019

@slaweet slaweet added this to the Version 1.14.0 milestone Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.