Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lisk-elements for @liskhq/lisk-client #2004

Closed
osvaldovega opened this issue May 13, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@osvaldovega
Copy link
Contributor

commented May 13, 2019

Description of the problem

RIght now HUB project is using the lisk-elements => version: 1.1.3 library and we should be using @liskhq/lisk-client => version: 2.0.0

File involve on this request.

./src//utils/rawTransactionWrapper.js:import Lisk from 'lisk-elements';
./src//utils/rawTransactionWrapper.test.js:import Lisk from 'lisk-elements';
./src//utils/account.js:import Lisk from 'lisk-elements';
./src//utils/hacks.test.js:import Lisk from 'lisk-elements';
./src//utils/hacks.js:import Lisk from 'lisk-elements';
./src//utils/api/btc/account.js:import Lisk from 'lisk-elements';
./src//utils/api/delegate.js:import Lisk from 'lisk-elements';
./src//utils/api/lsk/transactions.js:import Lisk from 'lisk-elements';
./src//utils/api/lsk/account.js:import Lisk from 'lisk-elements';
./src//utils/api/lsk/network.js:import Lisk from 'lisk-elements';
./src//utils/api/lsk/network.test.js:import Lisk from 'lisk-elements';
./src//utils/api/delegate.test.js:import Lisk from 'lisk-elements';
./src//utils/api/network.test.js:import Lisk from 'lisk-elements';
./src//utils/getNetwork.test.js:import { constants } from 'lisk-elements';
./src//utils/getNetwork.js:import Lisk from 'lisk-elements';
./src//components/statusBar/network.js:import Lisk from 'lisk-elements';
./src//components/headerV2/headerV2.js:import Lisk from 'lisk-elements';
./src//components/account/account.test.js:import Lisk from 'lisk-elements';
./src//components/account/account.js:import Lisk from 'lisk-elements';
./src//components/signMessage/confirmMessage.js:import Lisk from 'lisk-elements';
./src//actions/peers.js:import Lisk from 'lisk-elements';
./src//actions/network/lsk.js:import Lisk from 'lisk-elements';
./src//actions/network/lsk.test.js:import Lisk from 'lisk-elements';
./src//actions/peers.test.js:import Lisk from 'lisk-elements';

Suggested solution

@osvaldovega osvaldovega added this to New Issues in Not used anymore via automation May 13, 2019

@slaweet slaweet added type: refactoring and removed type:code labels May 15, 2019

@slaweet slaweet removed this from New Issues in Not used anymore May 15, 2019

@slaweet slaweet self-assigned this May 15, 2019

@slaweet slaweet closed this in 4911053 May 16, 2019

@slaweet slaweet added this to the Version 1.18.0 milestone May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.