Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify transaction actions #2018

Closed
slaweet opened this issue May 15, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@slaweet
Copy link
Member

commented May 15, 2019

Curent situation

There are too many transaction actions:

$ grep export src/actions/transactions.js
export const cleanTransactions = () => ({
export const transactionAdded = data => ({
export const testExtensions = () => ({
export const transactionsFilterSet = ({
export const transactionsUpdateUnconfirmed = ({ address, pendingTransactions }) =>
export const loadTransactionsFinish = accountUpdated =>
export const loadTransactions = ({ publicKey, address }) =>
export const transactionsRequested = ({
export const loadLastTransaction = address => (dispatch, getState) => {
export const loadTransaction = ({ id }) =>
export const transactionsUpdated = ({
export const sent = ({

The file is ove 300 lines

Expected situation

The actions should be simplified, file size reduced, duplicates identified.
The actions that are really necessary should be documented why they're needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.