Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refactor the actions, reducers and middleware for settings #2031

Closed
reyraa opened this issue May 16, 2019 · 0 comments

Comments

Projects
3 participants
@reyraa
Copy link
Member

commented May 16, 2019

Descriptions

This is a child ticket for #2020 .
With a short review over the code, we can find several redundant or obsolete actions. accordingly there are cases defined in the reducers switch-case statement which can be refactored or even removed.
The naming of the actions seem to need revision.

@slaweet slaweet added this to the Version 1.19.0 milestone May 16, 2019

@reyraa reyraa added this to Issues in Version 1.18.0 via automation May 27, 2019

@massao massao closed this in 1615d24 May 27, 2019

Version 1.18.0 automation moved this from Issues to Closed Issues May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.