Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting: HW wallet: Edit voting link is enabled #2097

Closed
Efefefef opened this issue Jun 4, 2019 · 0 comments · Fixed by #2121
Closed

Voting: HW wallet: Edit voting link is enabled #2097

Efefefef opened this issue Jun 4, 2019 · 0 comments · Fixed by #2121
Assignees
@slaweet
Labels
type: bug
Projects
Version 1.18.0
Milestone
Sprint 1

Comments

@Efefefef
Copy link
Contributor

Efefefef commented Jun 4, 2019

Steps to reproduce

  1. Login with HW wallet
  2. Check delegates and proceed to Confirmation page

Actual result

Edit voting link is present

Expected result

It should be disabled, as we should Confirm/Cancel tx on HW wallet.
Clicking Edit is not canceling tx on HW wallet but create a mess

Screenshot (if appropriate)

image
@Efefefef Efefefef added this to Issues in Version 1.18.0 via automation Jun 4, 2019
@Efefefef Efefefef changed the title HW wallet: Voting: Edit voting link is enabled Voting: HW wallet: Edit voting link is enabled Jun 4, 2019
@slaweet slaweet self-assigned this Jun 4, 2019
This was referenced Jun 4, 2019
Merged
Merged
slaweet added a commit that referenced this issue Jun 7, 2019
@slaweet
Merge pull request #2102 from LiskHQ/2097-fix-edit-voting-with-hw
33bb05f 
Hide "Edit voting" button for hardware wallets - Closes #2097
Version 1.18.0 automation moved this from Issues to Closed Issues Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slaweet slaweet

Labels
type: bug
Projects
No open projects
Version 1.18.0
  
Closed Issues
Milestone
Sprint 1
Development

Successfully merging a pull request may close this issue.

Merge voting bug fixes to development LiskHQ/lisk-desktop
2 participants
@slaweet @Efefefef