Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegates: Register as delegate button is visible to delegate #2103

Closed
Efefefef opened this issue Jun 4, 2019 · 2 comments

Comments

Projects
2 participants
@Efefefef
Copy link
Contributor

commented Jun 4, 2019

Steps to reproduce

  1. Login as delegate
  2. Go to Delegates page

Actual result

There is Register as delegate button

Expected result

There is no Register as delegate button

@Efefefef

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

I think better not to show this button in a guest mode as well.
Start voting is a call to action button, there is no need in Register Delegate.
It looks stupid showing 2 identical tooltips on hover

image

@Efefefef

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Unskip after fix
xit('Become a delegate link absent if I am a delegate', () => {

slaweet added a commit that referenced this issue Jun 5, 2019

Merge pull request #2106 from LiskHQ/2103-fix-hiding-register-delegat…
…e-button

Fix when "Register delegate" button is shown - Closes #2103

Version 1.18.0 automation moved this from Issues to Closed Issues Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.