Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "back to lisk.io" from login page #599

Closed
faival opened this issue Mar 23, 2018 · 6 comments
Closed

Remove "back to lisk.io" from login page #599

faival opened this issue Mar 23, 2018 · 6 comments

Comments

@faival
Copy link
Contributor

faival commented Mar 23, 2018

Expected Behaviour

  • There should not be a link giving the impression of a back button in login page (user might have come from lisk.io or by direct hit, or in electron app).

To avoid confusion for the user, let's rename the link to "Go to lisk.io", and change the orientation of the arrow to indicate a forwarding action instead of a back action.

Actual Behaviour

  • User can find a link with the look and feel of a back button.
@faival faival created this issue from a note in Sprint Board 26-03-18 (New Issues) Mar 23, 2018
@faival faival self-assigned this Mar 23, 2018
@faival faival changed the title Remove "back to lisk.io" from login page *easy Remove "back to lisk.io" from login page Mar 23, 2018
@faival faival added the *easy label Mar 23, 2018
@faival faival added this to New Issues in Version 0.4.0 via automation Mar 23, 2018
@faival faival added the update label Mar 23, 2018
@itssujan
Copy link
Contributor

@faival I went ahead with this small fix as its my first contribution to this project. I later realized that its assigned to you. Hope I didn't step on your toes...

@michaeltomasik
Copy link
Contributor

@itssujan Thank you for contributing 😄 We will be adding good first issue label on tasks that We think will be good for people that want to start contributing 🖥

@itssujan
Copy link
Contributor

@michaeltomasik that's cool...Look forward to being a regular contributor to Lisk...

@faival
Copy link
Contributor Author

faival commented Mar 27, 2018

@itssujan please review requirement changes to this issue, thanks.

@itssujan
Copy link
Contributor

@faival cool..i'll make the changes and open a PR

@itssujan
Copy link
Contributor

itssujan commented Mar 27, 2018

@faival Would this be good? The forward arrow looks odd though :)

screen shot 2018-03-27 at 11 35 46 am

@slaweet slaweet removed this from New Issues in Version 0.4.0 Mar 29, 2018
@slaweet slaweet added this to Issues in Version 0.5.0 via automation Mar 29, 2018
faival added a commit that referenced this issue Apr 3, 2018
Change wordings of back to lisk.io link - Closes #599
@faival faival closed this as completed Apr 3, 2018
Sprint Board 26-03-18 automation moved this from New Issues to Closed Issues Apr 3, 2018
Version 0.5.0 automation moved this from Issues to Closed Issues Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint Board 26-03-18
  
Closed Issues
Version 0.5.0
  
Closed Issues
Development

No branches or pull requests

4 participants