New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network showing for mainnet - Closes #1251 #1272

Merged
merged 4 commits into from Sep 13, 2018

Conversation

Projects
3 participants
@faival
Contributor

faival commented Sep 10, 2018

What issue have I solved?

-- #1251

How have I implemented/fixed it?

  • show it in mainnet if settings enabled
  • showing always otherwise

How has this been tested?

login to the three networks, with or without settings enabled

Review checklist

@faival faival self-assigned this Sep 10, 2018

@faival faival added this to Pull Requests in Version 1.3.0 via automation Sep 10, 2018

@slaweet

And please enable account.test.js in Jest

Show outdated Hide outdated src/components/account/account.js Outdated

faival added some commits Sep 12, 2018

@slaweet slaweet requested a review from Efefefef Sep 12, 2018

@Efefefef

Good job , now net indication is clear 👍

@slaweet slaweet merged commit e762a55 into 1.3.0 Sep 13, 2018

3 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.3.0 automation moved this from Pull Requests to Merged Pull Requests Sep 13, 2018

@slaweet slaweet deleted the 1251-network-indicator-not-shown-if-switch-networks-off branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment