New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding to urls on requesting LSK - Closes #1189 #1276

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
3 participants
@michaeltomasik
Member

michaeltomasik commented Sep 12, 2018

What issue have I solved?

-- #1189

How have I implemented/fixed it?

Encoded URI

How has this been tested?

Review checklist

@michaeltomasik michaeltomasik self-assigned this Sep 12, 2018

@michaeltomasik michaeltomasik added this to Pull Requests in Version 1.3.0 via automation Sep 12, 2018

@slaweet slaweet requested a review from Efefefef Sep 13, 2018

@Efefefef

Works now 👍

@michaeltomasik michaeltomasik merged commit 64f0d74 into 1.3.0 Sep 13, 2018

4 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 93.39%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.3.0 automation moved this from Pull Requests to Merged Pull Requests Sep 13, 2018

@michaeltomasik michaeltomasik deleted the 1189-encoding-url-on-request branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment