New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering error on tx details - Closes #1284 #1287

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
2 participants
@michaeltomasik
Member

michaeltomasik commented Sep 17, 2018

What issue have I solved?

-- #1284

How have I implemented/fixed it?

Added checking for pending transaction

How has this been tested?

Review checklist

@michaeltomasik michaeltomasik self-assigned this Sep 17, 2018

@michaeltomasik michaeltomasik added this to Pull Requests in Version 1.3.0 via automation Sep 17, 2018

@slaweet

Good job, Mike.

@slaweet slaweet added the ready label Sep 17, 2018

@michaeltomasik michaeltomasik merged commit 549d3c1 into development Sep 17, 2018

4 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-1287 at 93.323%
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.3.0 automation moved this from Pull Requests to Merged Pull Requests Sep 17, 2018

@michaeltomasik michaeltomasik deleted the 1284-rendering-error-tx-details branch Sep 17, 2018

@michaeltomasik michaeltomasik restored the 1284-rendering-error-tx-details branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment