New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosuggest delegate fetching bug - Closes #1351 #1690

Merged
merged 15 commits into from Feb 8, 2019

Conversation

Projects
4 participants
@michaeltomasik
Copy link
Member

michaeltomasik commented Jan 25, 2019

What issue have I solved?

#1351

How have I implemented/fixed it?

Added a simple regex to test if the input is a transaction ID or and address, if not and there is no results, it delays the action of the enter until the component receives the results.
If the value changes after the enter being queued, it removes the delay, and user has to press enter again.

How has this been tested?

Quickly type the starting of the delegate name or paste something and hits enter, it should wait a bit, and go to the page after the component receives the results.
If it's an address or transaction, it goes directly to the page, or to a result not found page.

Review checklist

@michaeltomasik michaeltomasik self-assigned this Jan 25, 2019

@michaeltomasik michaeltomasik added this to Pull Requests in Version 1.11.0 via automation Jan 25, 2019

@michaeltomasik michaeltomasik requested a review from osvaldovega Jan 25, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Jan 28, 2019

For delegates the solution is good. But for txs and addresses feels not very good
Can we do it conditionally? If the value doesn’t match tx or address - enter is disabled until results

renatomassao and others added some commits Feb 7, 2019

Merge branch '1351-autosuggest-delegate-fetching-bug' of github.com:L…
…iskHQ/lisk-hub into 1351-autosuggest-delegate-fetching-bug

@renatomassao renatomassao changed the base branch from 1.11.0 to development Feb 7, 2019

@renatomassao renatomassao changed the base branch from development to 1.11.0 Feb 7, 2019

renatomassao added some commits Feb 7, 2019

@osvaldovega
Copy link
Contributor

osvaldovega left a comment

tested the code and looks fine.
talking with @renatomassao we need to remove the old autosuggest folder and have just one.
The behavior of the autoSuggest in the interface looks fine too

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Feb 8, 2019

Recent searches autosuggestion is broken. I can see, that happened in the last sprint already, but know we implemented new logic on top. Let's check before-redesign-version say 1.9 as a reference and discuss

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Feb 8, 2019

👍 Finally, we have fully operational search

@Efefefef Efefefef added 🏗 in progress and removed ready labels Feb 8, 2019

@Efefefef

This comment has been minimized.

Copy link
Contributor

Efefefef commented Feb 8, 2019

Please check the code review comment above

renatomassao added some commits Feb 8, 2019

@renatomassao renatomassao merged commit dac62cf into 1.11.0 Feb 8, 2019

4 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.11.0 automation moved this from Pull Requests to Merged Pull Requests Feb 8, 2019

@renatomassao renatomassao deleted the 1351-autosuggest-delegate-fetching-bug branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment