New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement load more button on wallet - Closes 1635 #1728

Merged
merged 21 commits into from Feb 5, 2019

Conversation

Projects
2 participants
@renatomassao
Copy link
Contributor

renatomassao commented Feb 4, 2019

What issue have I solved?

#1635

How have I implemented/fixed it?

Added to TransactionsListV2 on /walletV2 route a Show More button, that loads more 25 transactions if clicked, and only shows up if there is more to show, if the table is showing all the transactions available already it shouldn't show up.
Will update to show the 30 most recent transactions, when replacing the wallet page.

How has this been tested?

go to /wallet so the application loads the transactions with an account with more than 25 transactions, after that go to /walletV2 and scroll to the bottom of the page, the show more button should be rendered, and clicking it should load more transactions at the bottom of the table.

Review checklist

renatomassao added some commits Feb 4, 2019

Merge branch '1635-implement-load-more-button-on-wallet' of github.co…
…m:LiskHQ/lisk-hub into 1635-implement-load-more-button-on-wallet

@renatomassao renatomassao self-assigned this Feb 4, 2019

@renatomassao renatomassao added this to Pull Requests in Version 1.11.0 via automation Feb 4, 2019

@renatomassao renatomassao changed the base branch from 1.11.0 to development Feb 4, 2019

@renatomassao renatomassao changed the base branch from development to 1.11.0 Feb 4, 2019

@slaweet
Copy link
Member

slaweet left a comment

As discussed, the loading state is missing.

renatomassao added some commits Feb 5, 2019

@renatomassao renatomassao force-pushed the 1635-implement-load-more-button-on-wallet branch from a5ed31d to 2a8aa91 Feb 5, 2019

@slaweet

This comment has been minimized.

Copy link
Member

slaweet commented Feb 5, 2019

As discussed

  • Incoming transactions don't show all 25 for me
  • "Transaction fee" should be only "Fee" in M breakpoint

renatomassao added some commits Feb 5, 2019

renatomassao added some commits Feb 5, 2019

Merge branch '1635-implement-load-more-button-on-wallet' of github.co…
…m:LiskHQ/lisk-hub into 1635-implement-load-more-button-on-wallet

@renatomassao renatomassao changed the base branch from 1.11.0 to development Feb 5, 2019

@renatomassao renatomassao changed the base branch from development to 1.11.0 Feb 5, 2019

@slaweet

slaweet approved these changes Feb 5, 2019

Copy link
Member

slaweet left a comment

Thank you, Massao 👍

@slaweet slaweet added ready and removed 👁 pending review labels Feb 5, 2019

@renatomassao renatomassao merged commit ee39b25 into 1.11.0 Feb 5, 2019

5 checks passed

Jenkins e2e tests e2e tests passed
Details
Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 93.764%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.11.0 automation moved this from Pull Requests to Merged Pull Requests Feb 5, 2019

@renatomassao renatomassao deleted the 1635-implement-load-more-button-on-wallet branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment